network: add ipv6 only global option #11831

borislitv · 2024-12-25T14:15:29Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support ipv6 only clusters

Which issue(s) this PR fixes:
Fixes #5649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

linux-foundation-easycla · 2024-12-25T14:15:33Z

The committers listed above are authorized under a signed CLA.

✅ login: borislitv / name: Boris (e2b0567, 5ca5844, a883e4a)

k8s-ci-robot · 2024-12-25T14:15:38Z

Welcome @borislitv!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-12-25T14:15:39Z

Hi @borislitv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yankay · 2024-12-26T03:29:28Z

/ok-to-test

MrFreezeex

Thanks for your contribution, the initiative looks great. I left a few comments on possible improvements to improve readability though.

roles/kubernetes/control-plane/templates/kubeadm-config.v1beta3.yaml.j2

roles/container-engine/cri-dockerd/templates/cri-dockerd.service.j2

roles/kubernetes/control-plane/tasks/kubeadm-setup.yml

roles/kubespray-defaults/defaults/main/main.yml

MrFreezeex · 2025-01-16T09:16:40Z

/label ci/extended

k8s-ci-robot · 2025-01-16T09:16:42Z

@MrFreezeex: The label(s) /label ci/extended cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ci/extended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MrFreezeex · 2025-01-16T09:17:11Z

/label ci-extended

MrFreezeex

Thanks!
/lgtm
/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

MrFreezeex · 2025-01-16T09:23:14Z

/retest

MrFreezeex · 2025-01-16T09:27:51Z

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

k8s-ci-robot · 2025-01-16T09:27:54Z

@MrFreezeex: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MrFreezeex · 2025-01-16T09:28:56Z

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

borislitv · 2025-01-16T12:23:38Z

Sorry, I had to add a small fix.
I found that ansible_default_ipv4 and ansible_default_ipv6 always available in hostvars, but may be '{}'

MrFreezeex

No worries, thanks for the additional fix!
/lgtm

borislitv · 2025-01-16T15:24:35Z

/assign @floryut

VannTen · 2025-01-18T20:22:17Z

Is there a way to test this in CI (the ipv6 only option, I mean) ?

Given the various places it touches, in order for the option to keep working, it should be tested. Otherwise unrelated changes have a high chance of silently breaking something.

borislitv · 2025-01-19T15:25:03Z

Is there a way to test this in CI (the ipv6 only option, I mean) ?

Given the various places it touches, in order for the option to keep working, it should be tested. Otherwise unrelated changes have a high chance of silently breaking something.

good idea, I'll try to make a test like ubuntu20-calico-dual-stack

VannTen · 2025-01-20T08:51:21Z

roles/kubespray-defaults/defaults/main/main.yml

@@ -548,9 +577,9 @@ ssl_ca_dirs: |-

 # Vars for pointing to kubernetes api endpoints
 kube_apiserver_count: "{{ groups['kube_control_plane'] | length }}"
-kube_apiserver_address: "{{ ip | default(hostvars[inventory_hostname]['fallback_ip']) }}"
+kube_apiserver_address: "{{ vars['ip' + default_net_mode] | default(hostvars[inventory_hostname]['fallback_ip' + default_net_mode]) }}"


ansible/ansible#15753 (comment)
vars is not supported by ansible, it's internal. You may want to use ansible.builtin.vars lookup

VannTen · 2025-01-20T08:53:01Z

roles/network_plugin/calico/templates/calico-config.yml.j2

-              {%   if enable_dual_stack_networks %}
+              {% if enable_ipv6only_stack_networks %}
+              "assign_ipv6": "true"
+              {% elif enable_dual_stack_networks %}
              "assign_ipv6": "true",
              {%   endif %}


Can you fix the spacing here since you're doing it on the associated if ?

VannTen · 2025-01-20T08:53:54Z

roles/network_plugin/flannel/templates/cni-flannel.yml.j2

      "Network": "{{ kube_pods_subnet }}",
      "EnableIPv4": true,
-{%   if enable_dual_stack_networks %}
+{%   endif %}
+{%   if enable_dual_stack_networks or enable_ipv6only_stack_networks %}
      "EnableIPv6": true,


Same here, since you're modifying the template take the opportunity to fix the spacing.

k8s-ci-robot · 2025-01-20T08:54:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borislitv, MrFreezeex
Once this PR has been reviewed and has the lgtm label, please ask for approval from floryut. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 25, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 25, 2024

k8s-ci-robot requested review from MrFreezeex and mzaian December 25, 2024 14:15

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2024

add ipv6 only option

a883e4a

borislitv force-pushed the ipv6only branch from bbfbf6f to a883e4a Compare December 25, 2024 14:26

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 26, 2024

MrFreezeex suggested changes Jan 14, 2025

View reviewed changes

borislitv force-pushed the ipv6only branch from 7b7c86f to fa978ff Compare January 16, 2025 05:43

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2025

borislitv force-pushed the ipv6only branch from fa978ff to 4483a43 Compare January 16, 2025 05:54

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2025

borislitv force-pushed the ipv6only branch from 4483a43 to bd89a97 Compare January 16, 2025 06:08

fix issues

5ca5844

borislitv force-pushed the ipv6only branch from bd89a97 to 5ca5844 Compare January 16, 2025 06:31

borislitv requested a review from MrFreezeex January 16, 2025 08:04

k8s-ci-robot added the ci-extended Run additional tests label Jan 16, 2025

MrFreezeex approved these changes Jan 16, 2025

View reviewed changes

k8s-ci-robot assigned MrFreezeex Jan 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 16, 2025

small variable check fix

e2b0567

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025

borislitv requested a review from MrFreezeex January 16, 2025 12:27

MrFreezeex approved these changes Jan 16, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025

k8s-ci-robot assigned floryut Jan 16, 2025

VannTen requested changes Jan 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

network: add ipv6 only global option #11831

network: add ipv6 only global option #11831

borislitv commented Dec 25, 2024 •

edited by k8s-ci-robot

Loading

linux-foundation-easycla bot commented Dec 25, 2024 •

edited

Loading

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

yankay commented Dec 26, 2024

MrFreezeex left a comment

MrFreezeex commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

MrFreezeex left a comment

MrFreezeex commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

borislitv commented Jan 16, 2025

MrFreezeex left a comment

borislitv commented Jan 16, 2025

VannTen commented Jan 18, 2025

borislitv commented Jan 19, 2025

VannTen Jan 20, 2025

VannTen Jan 20, 2025

VannTen Jan 20, 2025

k8s-ci-robot commented Jan 20, 2025

network: add ipv6 only global option #11831

Are you sure you want to change the base?

network: add ipv6 only global option #11831

Conversation

borislitv commented Dec 25, 2024 • edited by k8s-ci-robot Loading

linux-foundation-easycla bot commented Dec 25, 2024 • edited Loading

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

yankay commented Dec 26, 2024

MrFreezeex left a comment

Choose a reason for hiding this comment

MrFreezeex commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

MrFreezeex left a comment

Choose a reason for hiding this comment

MrFreezeex commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

MrFreezeex commented Jan 16, 2025

borislitv commented Jan 16, 2025

MrFreezeex left a comment

Choose a reason for hiding this comment

borislitv commented Jan 16, 2025

VannTen commented Jan 18, 2025

borislitv commented Jan 19, 2025

VannTen Jan 20, 2025

Choose a reason for hiding this comment

VannTen Jan 20, 2025

Choose a reason for hiding this comment

VannTen Jan 20, 2025

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 20, 2025

borislitv commented Dec 25, 2024 •

edited by k8s-ci-robot

Loading

linux-foundation-easycla bot commented Dec 25, 2024 •

edited

Loading